search

google / uuid

Go package for UUIDs based on RFC 4122 and DCE 1.1: Authentication and Security Services.
BSD 3-Clause "New" or "Revised" License
5.24k stars 363 forks source link

fix: use MustParse("xxx") instead of Must(Parse("xxxx")) #106

Closed kotaroyamazaki closed 6 months ago

kotaroyamazaki commented 1 year ago

Must(Parse("xxxx")) is considered legacy code to forced uuid to parse because the code is pre-implementation of Must(Parase("xxxx"))(https://github.com/google/uuid/pull/26)

This one is simpler.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

noahdietz commented 1 year ago

Hello! If you are still interested in making this contribution, please follow the instructions above to sign the CLA. Then, also change the instances of Must(Parse( in tests to MustParse as well, please.

If you are not interested in continuing with this PR, do not respond in a few working days, or do not want to sign the Google CLA, I will make the change myself. Thanks.

bormanp commented 11 months ago

Please address the failed check about commit messages. Other than that I see no problem with this code.

kotaroyamazaki commented 6 months ago

@noahdietz @bormanp Sorry for the delay. I've fixed the CI error and also updated the test code.