Closed kotaroyamazaki closed 6 months ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Hello! If you are still interested in making this contribution, please follow the instructions above to sign the CLA. Then, also change the instances of Must(Parse(
in tests to MustParse
as well, please.
If you are not interested in continuing with this PR, do not respond in a few working days, or do not want to sign the Google CLA, I will make the change myself. Thanks.
Please address the failed check about commit messages. Other than that I see no problem with this code.
@noahdietz @bormanp Sorry for the delay. I've fixed the CI error and also updated the test code.
Must(Parse("xxxx"))
is considered legacy code to forced uuid to parse because the code is pre-implementation ofMust(Parase("xxxx"))
(https://github.com/google/uuid/pull/26)This one is simpler.