search

google / uuid

Go package for UUIDs based on RFC 4122 and DCE 1.1: Authentication and Security Services.
BSD 3-Clause "New" or "Revised" License
5.16k stars 362 forks source link

fixed issue #131 by improving the Parse function in uuid.go + unit tests #132

Closed theghostmac closed 9 months ago

theghostmac commented 9 months ago

I attempted to solve the most recently opened error here, but it's sensitive as other functions and test functions rely on the original implementation.

If my improvement on the Parse() function is correct, then both TestNullUUIDMarshalJSON and TestJSONUnmarshal needs to either be rewritten or fed with new data.

Also, two test data failed, as I mentioned.

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

theghostmac commented 9 months ago

Okay, let me remove the PR. Thanks.