feat: add Max UUID constant

google / uuid

Go package for UUIDs based on RFC 4122 and DCE 1.1: Authentication and Security Services.

BSD 3-Clause "New" or "Revised" License

5.16k stars 362 forks source link

feat: add Max UUID constant #149

Closed it512 closed 6 months ago

it512 commented 6 months ago

add Max uuid

bormanp commented 6 months ago

LGTM, but please address the conventional commits error in the tests. Thank you!

it512 commented 6 months ago

Please give me a hint, which questions need to be corrected? Thanks! I add go 1.18 support in go.mod

noahdietz commented 6 months ago

Please give me a hint, which questions need to be corrected? Thanks! I add go 1.18 support in go.mod

Can you please revert this and send it in a separate commit? Best to keep these things separate.

noahdietz commented 6 months ago

I fixed the title and applied automerge. Bots will squash-merge the commits with the title as the commit, which conforms to the conventional commit spec.

Please remove the Go 1.18 change though.

it512 commented 6 months ago

ok already revert . Thank you!