search

google / uuid

Go package for UUIDs based on RFC 4122 and DCE 1.1: Authentication and Security Services.
BSD 3-Clause "New" or "Revised" License
5.26k stars 362 forks source link

Add support for bazel BUILD #30

Closed paradoxengine closed 6 years ago

paradoxengine commented 6 years ago

Hello, I've just added a dependency to this project in a bazel compiled system and it was a bit clunky with no BUILD file around. My current dependency looks like this: new_git_repository( name = "google_uuid", build_file_content = """ load("@io_bazel_rules_go//go:def.bzl", "go_prefix") load("@io_bazel_rules_go//go:def.bzl", "go_library") go_prefix("github.com/google/uuid") go_library( name = "go_default_library", srcs = glob([".go"], exclude=["_test.go"]), deps = [ ], visibility = ["//visibility:public"], ) """, tag = "0.2", remote = "https://github.com/google/uuid", )

It would be fairly simple to add a BUILD file - if you are ok with that I can just send a pull request (and simplify my dependencies ;-) ).

fedir commented 6 years ago

IMHO, it's too specific, and should not be included in this package. Probably, You could just publish a gist for those, who could need it.

paradoxengine commented 6 years ago

I can certainly add what I have above in a Gist, but it will remain clunky for folks using it. I don't feel strongly about this to be honest, just figured it would be convenient and Googly. I'm ok with a project admin making the call and closing the request :)

pborman commented 6 years ago

Well, at a minimum it would need to be a BUILD.bazel file as BUILD is what is used by "blaze", Google's internal build system (bazel is the public version of blaze).

I am not inclined to add a BUILD.bazel, or Makefile, or CMakefile, or ANT file, or ...

You see my dilemma :-)

paradoxengine commented 6 years ago

Fair, I agree with your point.