google / uuid

Go package for UUIDs based on RFC 4122 and DCE 1.1: Authentication and Security Services.
BSD 3-Clause "New" or "Revised" License
5.24k stars 363 forks source link

hash.go hash error covered and linter error fixed #71

Closed yusufpapurcu closed 3 years ago

yusufpapurcu commented 3 years ago

Error covered without change function definition

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

yusufpapurcu commented 3 years ago

@googlebot I signed it!

yusufpapurcu commented 3 years ago

So we need to add //nolint:errcheck because if we don't add it will fails in linting.

pborman commented 3 years ago

Thank you. FYI, the other option is just saying _, _ = h.Write(...)