Some general Vector4 optimizations

google / vector_math.dart

A vector math package for 2D and 3D applications

https://pub.dev/packages/vector_math

Other

310 stars 78 forks source link

Some general Vector4 optimizations #295

Closed spydon closed 10 months ago

spydon commented 1 year ago

Since the Vector4.zero constructor was already a normal named constructor it was already possible to extend the class.

~~Converts all factory constructors (except Vector4.random) to named constructors that directly sets the storage instead of calling intermediary methods to do it.~~
Simplifies length2, dot, isInfinite and isNaN.
Optimizes reflect, relativeError and absoluteError so that they don't create extra Vector4 objects.
Orders all operations made on _v4storage from 1 to 0 so that it is consistent across the class and guarantees that bounds checking is only done once.

coveralls commented 1 year ago

coverage: 26.312% (-0.06%) from 26.369% when pulling 441d2535de494500fe2f8dc8c13054189e77308b on spydon:fix/vector4 into 47a08ea918a2491a34c14a18caf5428b8019a1f3 on google:master.

johnmccutchan commented 1 year ago

What is going on with the code coverage? That is a steep drop.

spydon commented 1 year ago

What is going on with the code coverage? That is a steep drop.

That is very strange... Are you sure the coveralls check ran properly?

kevmoo commented 1 year ago

Just reran for giggles. It seems coverage fell off a cliff before this change. Maybe rebase on master?

spydon commented 1 year ago

Just reran for giggles. It seems coverage fell off a cliff before this change. Maybe rebase on master?

It has the same coverage percentage on master now 🤷‍♂️ (I can rebase tomorrow when I'm back at the computer)