Closed blueyed closed 6 years ago
@googlebot I signed it!
CLAs look good, thanks!
You'll want to change .travis.yml
and plugin/coverage.vim
to update the minimum Maktaba version to at least 1.12.0 (was 1.9.0), since that's the version that added maktaba#python#Eval
.
(1.14.0 was the version that added python3 support to maktaba#python#
, but I don't think we need to explicitly test that version in addition - we're already testing against Maktaba master.)
@malcolmr Thanks. What about the comment there? (https://github.com/google/vim-coverage/blob/97ad576f3c29302fb9d9def698f3ebc50f6a3413/.travis.yml#L4)
Ah, seems to have moved to plugin/coverage.vim.
@malcolmr Thanks! Please squash-merge it then - or should I force-push already? (might save a build then, so I will do it)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g.
I signed it!
) and we'll verify. Thanks.