search

google / vim-coverage

Apache License 2.0
102 stars 22 forks source link

Travis: fix neovim #32

Closed blueyed closed 5 years ago

blueyed commented 6 years ago

Vroom crashes. Master branch is reported to be OK: https://github.com/google/vroom/issues/106

dbarnett commented 6 years ago

So update vroom release and then apply this, right? Why doesn't it need the --allow-external sudo anymore?

dbarnett commented 6 years ago

I checked the new vroom release on maktaba (google/vim-maktaba#214). The neovim tests still have preexisting issues causing them to hang (see google/vroom#83 and google/vroom#100), so even if they are currently passing here I'd leave the allow_failures override in place until that's fixed.

blueyed commented 6 years ago

Why doesn't it need the --allow-external sudo anymore?

IIRC this options does not exist anymore, and caused pip to fail.

blueyed commented 6 years ago

Also mentioned in the commit message. I've removed 135af1f.

dbarnett commented 6 years ago

You can update vroom version to 0.13.0, and then LGTM.

blueyed commented 6 years ago

You can update vroom version to 0.13.0, and then LGTM.

Done.

Unfortunately Neovim now appears to hang on a hit-enter prompt: https://github.com/encode/django-rest-framework/pull/6047/files#diff-b91f3d5bd63fcd17221b267e851608e8R33.

dbarnett commented 6 years ago

Right, mentioned that in an earlier comment. The other updates are useful in themselves, so just add the allow_failures override back and you can proceed w/ submitting.

dbarnett commented 5 years ago

LMK if you won't get around to updating and submitting this, and I can take over submitting the changes if so.

blueyed commented 5 years ago

@dbarnett Please take over.

dbarnett commented 5 years ago

Done, obsoleted this PR with my #38. Required a surprising number of small tweaks to get it working again.