search

google / vim-coverage

Apache License 2.0
101 stars 22 forks source link

Require maktaba 1.9.0 and add plugin version 0.0.1 #5

Closed dbarnett closed 9 years ago

dbarnett commented 9 years ago

Any thoughts on how I'm doing the version check here? Other plugins do it in bootstrap.vim, but that seems wrong. It won't get triggered for most users. For other plugins that don't have such a handy place already available to add this check, we could add it in instant/flags.vim (but errors tend to be uglier) or in autoload (but that can be triggered very late).

malcolmr commented 9 years ago

Retrospective LGTM, since I couldn't comment earlier. I think this approach is fine.