search

google / vimdoc

Helpfile generation for vim
Apache License 2.0
291 stars 29 forks source link

Attempt to address #119 #139

Open S0AndS0 opened 1 month ago

S0AndS0 commented 1 month ago

Note: I'm not yet savvy enough with the source to sort-out why self.locals.get is returning None instead of an empty string.

But this seems to work well enough for me :shrug:

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

S0AndS0 commented 1 month ago

Once you've signed, follow the "New Contributors" link at the bottom of that page to update this check.

There is no "New Contributors" link at the bottom of that page to update this check to follow⁉

dbarnett commented 1 month ago

There is no "New Contributors" link at the bottom of that page to update this check to follow⁉

Dunno about what links to what anymore, but I think if you just comment "I signed it" here it'll recheck.

S0AndS0 commented 1 month ago

Dunno about what links to what anymore, but I think if you just comment "I signed it" here it'll recheck.

Thanks @dbarnett!

"I signed it"

Edit 2024-10-19

:facepalm: Oh the link to click be in the "Details" for the blockage. Now I think the hitch in this PR's giddy-up is "Review required" section.