search

google / vimdoc

Helpfile generation for vim
Apache License 2.0
290 stars 37 forks source link

Improve section/order handling #89

Closed dbarnett closed 9 years ago

dbarnett commented 9 years ago

Fix having to explicitly declare every built-in section when you use @order and complain if you have redundant definitions for the same section.

Fixes #88.

Also adds a few initial tests to get the ball rolling on #29.

malcolmr commented 9 years ago

Mostly looks reasonable, but see above.

malcolmr commented 9 years ago

LGTM whichever way you decide to go on the above, btw.

dbarnett commented 9 years ago

BTW, I'm still updating and addressing the other comments.

I think I do want to get the implicit order into the "natural order" that makes intuitive sense to me, but I'm still having trouble describing the algorithm in plain English. Anyway, I'm adding some tests for the ordering behavior since it's clearly non-trivial. =)

dbarnett commented 9 years ago

PTAL. Improved the default ordering and added more tests for it.

malcolmr commented 9 years ago

LGTM, thanks (and sorry for the delay).