Add flags to control alignment steps

terpste commented 5 months ago

Hi everyone, I am opening this PR that adds two flags to control whether global alignment and (local) fine realignment should run. Allowing to switch off the alignment steps for cases that do not need it can be an important optimization in terms of run time.

In our use cases the reference and degraded signals do not have any inter-frame lags, so omitting the fine realignment step and setting the search window to zero provides more than 3x faster runs.

The proposed changes include:

Addition of a disable_global_alignment flag, that skips the Alignment::GloballyAlign() call and sets the global lag to 0.0
Addition of a disable_realignment flag, that skips the ComparisonPatchesSelector::FinelyAlignAndRecreatePatches() call
Adjustments in the pybind wrapper and test, to mirror the flags additions

terpste commented 4 months ago

@mchinen Thank you for initiating the checks jobs! It seems windows-amd64 is failing and the errors seem to mention the Bazel and Visual C++ build tools configuration in the CI. I was seeing similar results at my tests in the forked repo as well. Could this be caused by this PR or is it an issue with master branch as well?

mchinen commented 4 months ago

Hi @terpste ! Thanks for the PR. The failure indeed looks unrelated to your PR, related to basic MSVC build tools. FYI I no longer work at Google. Someone at Google needs to look at it and merge it into their backend when this is closed. So I'm unsure if I'm the one who should merge/review. I'll try looping someone in.

google / visqol

Add flags to control alignment steps #110