search

google / visqol

Perceptual Quality Estimator for speech and audio
Apache License 2.0
641 stars 118 forks source link

Update mac and linux build instructions for bazel 5.1.0 #69

Closed FeargusOG closed 2 years ago

FeargusOG commented 2 years ago

Updating:

FeargusOG commented 2 years ago

Hey @mchinen ! A similar PR confirming that it builds on Mac/Linux with bazel 5.1.0 also.

Oh, one other question - I notice that the unit test instructions were removed from the README - is there a reason to keep them removed? The unit tests weren't working on Mac initially, but they will work when the --features=-supports_dynamic_linker flag is used e.g. bazel test :alignment_test --features=-supports_dynamic_linker. I was thinking of adding the instructions back in (with this flag for Mac detailed) unless there was a reason to keep them out of the readme.

mchinen commented 2 years ago

Thanks!

Re the question: The unit test README removal was accidental - I suppose we did not ingest the most recent version of GitHub and overwrote it when we exported this version. I will look into that. For me, the unit tests on mac work with basic Xcode tools installed without that flag. If there are some cases where we need that flag we should add it to .bazelrc.

FeargusOG commented 2 years ago

Ah interesting @mchinen ! I'll do some more looking into what is different about my machine/xcode install that meant I required that flag.