search

google / visqol

Perceptual Quality Estimator for speech and audio
Apache License 2.0
641 stars 118 forks source link

Make ViSQOL pip installable #81

Closed aluebs closed 1 year ago

aluebs commented 1 year ago

Still uses bazel to build the protobuf python files and pybind11 dynamic library, since it is the easiest way I was able to deal with all the necessary dependencies and keep everything in sync. But please let me know if there is a cleaner way.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mchinen commented 1 year ago

Very nice! So users run setup.py, then are able to call pip install path/to/visqol?

aluebs commented 1 year ago

Users in the visqol root dir can install it directly running: pip install -e .. Bazel is still required to build though.

mchinen commented 1 year ago

Thanks, merged!