search

google / voice-iot-maker-demo

Google Actions + Particle Photon (via Dialogflow)
https://aiyprojects.withgoogle.com/voice/
Apache License 2.0
68 stars 26 forks source link

Migrate to Dialogflow v2? #2

Open jeremykeen opened 6 years ago

jeremykeen commented 6 years ago

Do you intend to migrate the code to Dialogflow V2?

mikedory commented 6 years ago

Hey @jeremykeen — we do indeed, but we'd also welcome any contributions meantime.

priyanktyagi89 commented 6 years ago

@mikedory : I just found that you are storing id of intent of your agent in github. I think, it might put your agent on risk.

I mean https://github.com/google/voice-iot-maker-demo/blob/master/dialogflow-agent/voice-iot-maker-demo/intents/Default%20Fallback%20Intent.json

{ "id": "ac2178f6-e492-48e0-b7b2-72560279254a", "name": "Default Fallback Intent", "auto": false,

mikedory commented 6 years ago

Hey @priyanktyagi89 — thanks for calling that out. That ID corresponds to a sample app, and should be replaced when you import the app via Dialogflow. However, happy to accept a pull request to remove the ID, if you'd like to send one.

avidan commented 4 years ago

i'd also love to see this migrated for V2. this was powering my particle powered vending machine: https://twitter.com/kane/status/1129451259860099072?s=20

i am doing my best to learn about V1 to V2 migration requirements so i can build a pull request, but so far its slow going :)

thanks for what you built thus far Mike! if you find yourself in SF, know there is an automated beer waiting for you

mikedory commented 4 years ago

@avidan That'd be awesome! Please do send a pull request if you end up getting it working.

And that's too kind, thank you much! Waving a non-automated hello back from the east coast. 👋 😂