search

google / volley

https://google.github.io/volley
Apache License 2.0
3.37k stars 751 forks source link

Only log debug messages when DEBUG is True #453

Closed vorlon77 closed 1 year ago

vorlon77 commented 1 year ago

According to the internal comments and other usage, this message should only be logged when DEBUG is True. The log entry can potentially contain sensitive data in the case where authentication tokens are part of a GET request and so it should be possible for the user of Volley to disable logging by setting DEBUG to False even in the case where the network request is "slow."

Fixes #452

vorlon77 commented 1 year ago

I incorporated your suggested changes and I think I also caught all of the comments that referenced "slow"

jpd236 commented 1 year ago

Thanks, looks good! Appreciate your contributions and discussion.