Wrong secondary DNS ip address

google / vpn-libraries

The VPN client libraries provide a reference implementation for a secure, encrypted tunnel for connected devices. Full Public report: https://research.nccgroup.com/2021/04/08/public-report-vpn-by-google-one-technical-security-privacy-assessment/

http://goo.gle/vpn-whitepaper

Apache License 2.0

550 stars 44 forks source link

Wrong secondary DNS ip address #3

Closed bcadiot closed 2 years ago

bcadiot commented 2 years ago

It seems the IP address used for the second DNS is wrong 8.8.8.4 instead of 8.8.4.4

https://github.com/google/vpn-libraries/blob/main/krypton/session.cc#L327

  AddDns("8.8.8.4", TunFdData::IpRange::IPV4, 32,
         tun_fd_data->add_tunnel_dns_addresses());

ronaldkozoman commented 2 years ago

Hi, thank you for your review and the Issue! This has been fixed, and we will include this in our next OSS release. Thanks again for your interest and help.