google / vroom

Launch vim tests
Apache License 2.0
274 stars 27 forks source link

Detect neovim vs. vim automatically #132

Open dbarnett opened 2 weeks ago

dbarnett commented 2 weeks ago

Currently if you run vroom it tries to invoke vim classic as 'vim', or if you pass the --neovim option it tries to invoke neovim as 'nvim'. This gets annoying in a few ways:

It would be nice to generalize that and add inference so that you have more control over which vim executable it's invoking and it can more automagically figure out which options to pass to whichever vim variant it's pointed at.

dbarnett commented 2 weeks ago

FYI I have the improvements for this implemented in https://github.com/dbarnett/vroom/tree/detect_vim, but they're stacked on top of #133 so I'll wait to send a PR until that one's merged.

snu5mumr1k commented 2 weeks ago

I would like to re-word this issue. Something like 'Allow configuration of the path to vim/nvim executable'. And as part of what needs to be done improve on the errors quality.

The root cause for it is not that we don't do things automatically, but that we use a command name instead of a file and don't allow the overwrite.

For a testing framework making automatic choices is arguably less than desirable, as the mistake in configuration may survive unnoticed.

A side note: I don't think aliases matter as much, because we don't use bash, but symlink collisions in path are very much an obvious problem.

dbarnett commented 2 weeks ago

That name SGTM. LMK if anything beyond the title sounds bad to you.