search

google / vroom

Launch vim tests
Apache License 2.0
274 stars 27 forks source link

Neovim mode fails in replace_termcodes on non-ASCII input #76

Open dbarnett opened 9 years ago

dbarnett commented 9 years ago

Non-ASCII characters in vroom lines are making vroom --neovim fail with errors like UnicodeDecodeError: 'utf-8' codec can't decode bytes in position 55-56: invalid continuation byte.

This seems to have broken when I started using vroom.DecodeHook in a3d8a384b1, and looks like a bug in the neovim projects: neovim/python-client#52. It causes failures in maktaba/vroom/pluginsignals.vroom.

dbarnett commented 9 years ago

This might be a separate bug, but maktaba/vroom/pluginsignals.vroom still fails for me. Now it's running

call maktaba#plugin#Install(maktaba#path#Join([g:repo, 'weird¬p…l✓u↓g⏎i‽n']))

and ending up defining g:installed_weird_p___l_u_g_i___n instead of g:installed_weird_p_l_u_g_i_n. Seems like a badly-encoded string is getting passed through and shows up as having extra characters (which maktaba substitutes with underscores).

dbarnett commented 9 years ago

Dug in a little more. I don't think this has been fixed properly yet. Looks like the actual input is being encoded as 'weird¬pâ<80>¦l✓u↓g⏎iâ<80>½n'.