Open dan-nom opened 5 years ago
Sure - I'd done some thinking on this behind the scenes, but hadn't written it down yet - so thanks for prompting the conversation!
SELECT [] FROM `project.dataset.table`
, a JavaScript UDF example, etc would be enough.SELECT * FROM
project.dataset.TABLES` until then (a snippet!)https://console.cloud.google.com/bigquery?project=${projectId}&j=${jobId}&page=queryresults
would do the trick. I'm OK with Markdown, but the table rendering code (since BQ has nested fields) is already fragile, which isn't great, so perhaps even just replace the current table formatting with a Markdown driven engine if there's something more robust here.In order of "priority" and taking into account ease-of-implementation) I see it as: exporting results locally > SQL formatting > sidebar > open in browser > additional rendering options.
Happy to divvy up the work here too. I can't commit mountains of time to this, and I have a number of other OSS projects that keep me treading water as-is, but I can at the very least commit to timely reviews & feedback.
Thanks for the reply! I also cannot commit a huge amount of time, but happy to add in features where I can.
Perhaps a next step is to file some issues for more incremental improvements which I (or other contributors 🤞) can work on when we have the time.
For the bigger chunks of work, like a language server, where some consideration is needed for architecture we could either create issues for discussion or docs for planning?
Happy to follow your lead on best way to proceed.
Yep - I think adding some issues for these will be useful to help scope.
RE: the language server - I think leaving that until there's more obvious adoption is acceptable. We can however certainly implement format-on-save functionality for any mode: SQL file - as a config option that can also format the query in the editor buffer prior to sending it to the BQ API (formatting afterwards will cause a query-cache miss).
We can use https://github.com/zeroturnaround/sql-formatter - which is well documented, tested and more than fast enough.
Example: https://runkit.com/elithrar/sql-format-bigquery-example
On Fri, Oct 19, 2018 at 9:49 AM Dan Massey notifications@github.com wrote:
Thanks for the reply! I also cannot commit a huge amount of time, but happy to add in features where I can.
Perhaps a next step is to file some issues for more incremental improvements which I (or other contributors 🤞) can work on when we have the time.
For the bigger chunks of work, like a language server, where some consideration is needed for architecture we could either create issues for discussion or docs for planning?
Happy to follow your lead on best way to proceed.
— You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/google/vscode-bigquery/issues/3#issuecomment-431426835, or mute the thread https://github.com/notifications/unsubscribe-auth/AABIcKRGxPKrhFG4OpJIhg2VVTBQkcKkks5umgKLgaJpZM4XvrKC .
--
Hey Matt, it would be great to understand more of your vision for what could be in and out of scope for this extension in the future. I have a pretty long wishlist for my ideal VSCode/BigQuery workflow, but to pick out a few things that would be cool:
I'm super excited about the possibilities here: BigQuery + VSCode + Git could be really powerful!