google / vulncode-db

Vulncode-DB project
https://www.vulncode-db.com
Apache License 2.0
575 stars 71 forks source link

Update Authlib and its usage #32

Closed lepture closed 4 years ago

lepture commented 4 years ago

Authlib can parse id_token in an easy way. Just pass Google OpenID Connect discovery endpoint to oauth.register, it will handle everything for you.

Check this demo:

https://github.com/authlib/demo-oauth-client/blob/master/flask-google-login/app.py

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

lepture commented 4 years ago

I'm not going to sign this CLA. If you can't merge this PR without CLA, you can change the code yourself.

evonide commented 4 years ago

Hi Hsiaoming,

Thank you very much for the time to create a PR and the simplification :)! As I can't merge the PR, I've adjusted the code in https://github.com/google/vulncode-db/commit/bef3b0f24b7abe969e4266fe48e54e5a1a69756f as per your suggestion.