search

google / vulncode-db

Vulncode-DB project
https://www.vulncode-db.com
Apache License 2.0
575 stars 71 forks source link

Mark required fields in forms #78

Closed bluec0re closed 3 years ago

bluec0re commented 3 years ago

Is your feature request related to a problem? Please describe. Forms currently do not indicate which fields are optional or required.

Describe the solution you'd like Mark required or optional fields visually,

Additional context WTForms adds a required css class to the fields which could be used for this.

evonide commented 3 years ago

Actually, we don't need this as leaving empty mandatory fields will bring up an indicator anyway. I've added but commented out a red astersik in CSS for the fields that are set to required with https://github.com/google/vulncode-db/commit/42f105ab45bc59d5b76203e7d5c346a12eff9539 though.

bluec0re commented 3 years ago

I'm still for having these as otherwise users will not know what is required and what not until they try to submit

evonide commented 3 years ago

Resolved with https://github.com/google/vulncode-db/commit/efc2e5ef2670cc869a7c8cc37427eed14dc4a078.