google / vulncode-db

Vulncode-DB project
https://www.vulncode-db.com
Apache License 2.0
575 stars 71 forks source link

Fix database credentials when frontend is run with docker #89

Closed 3wnbr1 closed 3 years ago

3wnbr1 commented 3 years ago

When running VCBD with docker using this sequence :

Running crawl_patches using docker-admin.sh will fail at some point due to database credentials environment variables not being passed to the frontend container.

sqlalchemy.exc.OperationalError: (MySQLdb._exceptions.OperationalError) (1045, "Access denied for user 'root'@'172.18.0.4' (using password: NO)")

Setting the default environment variable value seems LGTM but there might be better designs to consider.

evonide commented 3 years ago

This looks good as a fix for now thanks!