Open romanholidaypancakes opened 1 year ago
Hi there!
Thanks for the report. I should've included a section on supported OSes in the README. While the code does work on Windows when built with a manually created Visual Studio project, I never updated the Bazel build files for VxSig for that.
You could try and replace the patch commands in the WORKSPACE
file with something more appropriate on Windows (a Powershell script maybe?). I'm not yet sure how to fix this and not break the Linux build.
maybe it is more appropriate to provide vs project files in windows
Bummer, still no compilation on Windows, because the protobuf Bazel build is broken in 23.1
:
ERROR: C:/users/win11-devel/_bazel_win11-devel/lnjrh73z/external/protobuf~23.1/src/google/protobuf/compiler/csharp/BUILD.bazel:22:11: Compiling src/google/protobuf/compiler/csharp/csharp_enum.cc [for tool] failed: (Exit 2): cl.exe failed: error executing CppCompile command (from target @@protobuf~23.1//src/google/protobuf/compiler/csharp:csharp) C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\bin\HostX64\x64\cl.exe ... (remaining 1 argument skipped)
bazel-out/x64_windows-opt-exec-ST-13d3ddad9198/bin/external/protobuf~23.1/src/google/protobuf/compiler/csharp/_virtual_includes/csharp\google/protobuf/compiler/csharp/csharp_enum.h(37): fatal error C1083: Cannot open include file: 'google/protobuf/compiler/csharp/csharp_source_generator_base.h': No such file or directory
Target //vxsig:vxsig failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 176.753s, Critical Path: 17.42s
INFO: 203 processes: 6 internal, 197 local.
ERROR: Build did NOT complete successfully