search

google / wasefire

Secure firmware framework focusing on developer experience
https://google.github.io/wasefire/
Apache License 2.0
85 stars 20 forks source link

Software HMAC-SHA-256 should use board SHA-256 when available #157

Closed ia0 closed 1 year ago

ia0 commented 1 year ago

When enabling software HMAC-SHA-256, the SHA-256 used as part of the HMAC is also done in software, even though there might be a non-software SHA-256 implementation in the board.

This is blocked by #156.

As part of fixing this issue, it would be worth distinguishing between Unsupported and Software. This permits getting a compile error when asking for Software without the correct dependencies. It shouldn't be a usability issue by providing macros to select the correct implementation based on a feature. See https://github.com/ia0/wasefire/tree/issue-157 for the initial attempt.

ia0 commented 1 year ago

This was fixed by #174. I'm going to ignore splitting Unsupported and Software. A separate issue may be opened if this is believed to be useful enough. Right now convenience is more useful.