search

google / watchface

Apache License 2.0
30 stars 3 forks source link

Adds support for resources.arsc parsing #22

Closed garanj closed 4 months ago

garanj commented 6 months ago

Adds handling for release APKs where Android Resources are obfuscated.

Updates tests to test with obfuscated APKs Adds test to ensure non-obfuscated APKs are also tested

garanj commented 4 months ago

I think we should wait for this until we have tests. Too invasive 👍 Tests are now passing for obfuscated APKs, non-obfuscated APKs and bundles.

garanj commented 4 months ago

Let's wait until we address loading the assets into memory before merging this

Thanks, I've moved to a streamed approach.

lucianbc commented 4 months ago

Let's wait until we address loading the assets into memory before merging this

Thanks, I've moved to a streamed approach.

Looks good to me, but I noticed that with this change, some other code can go away. Once that is gone, this can be merged.

garanj commented 4 months ago

Let's wait until we address loading the assets into memory before merging this

Thanks, I've moved to a streamed approach.

Looks good to me, but I noticed that with this change, some other code can go away. Once that is gone, this can be merged.

Thanks, done!