search

google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.43k stars 3.02k forks source link

remove usage of the gulp-uncss plugin #876

Closed bvahdat closed 8 years ago

bvahdat commented 8 years ago

Thanks to #853 now the gulp-uncss plugin gets called at the right place, namely inside the styles task instead of the html task. But the problem is now that it cuts off too much from the used css. Compare the two sceenshots below:

The difference is reflected through the content of ./tmp/styles/main.css.

Another possible solution (compared to what this PR proposes) could be the ignore option which would solve the issue by the Material Design Lite here, but is not a general solution for people using web-starter-kit for their own used libraries, like Angular Material Design etc.

/cc @addyosmani

addyosmani commented 8 years ago

I'm actually now fine with us dropping use of UnCSS in WSK. It exists as a plugin should folks want to manually add it in, but in terms of complexity it's a little OTT for the average user.