google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.43k stars 3.02k forks source link

Example code uses old version of Material Design Lite #884

Closed kmturley closed 7 years ago

kmturley commented 7 years ago

Web Starter Kit currently uses:

<link rel="stylesheet" href="https://storage.googleapis.com/code.getmdl.io/1.0.6/material.indigo-pink.min.css">
<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">
<script src="https://storage.googleapis.com/code.getmdl.io/1.0.6/material.min.js"></script>

But the official page at: https://getmdl.io/started/index.html#download

Recommends:

<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">
<link rel="stylesheet" href="https://code.getmdl.io/1.2.0/material.indigo-pink.min.css">
<script defer src="https://code.getmdl.io/1.2.0/material.min.js"></script>

The differences are:

Garbee commented 7 years ago

We need to wait for a patch to land for 1.2 before upgrading. I'm working on it again today to try and find the full fix to the problem that has shown up.

Garbee commented 7 years ago

V 1.2.1 is now tagged, WSK should be updated to use that since it has a critical fix for the drawer toggle icon alignment.

cc @addyosmani

mikeerickson commented 7 years ago

@garbee has this happened yet?