google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.43k stars 3.02k forks source link

HTML partial support #890

Open k0ff33 opened 7 years ago

k0ff33 commented 7 years ago

As mentioned in #889, provides a basic ability to separate big and ugly html files into smaller partials, without adding any complicated template engine.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


k0ff33 commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

JimmyMultani commented 7 years ago

Any news on this?

Victory commented 7 years ago

I pulled these changes into my project and it worked a charm.

+1 to add this to main branch.

sbarfurth commented 7 years ago

I would like to suggest that instead of constraining partials into a folder, they could instead be prefixed with an underscore. This would leave more room with folder structure and seems compliant with what is usually done with Sass.