google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.42k stars 3.01k forks source link

useref simplified (issue #913) #914

Closed vorburger closed 3 years ago

vorburger commented 7 years ago

strongly inspired by how I've found it's done in Yeoman generator-webapp

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


vorburger commented 7 years ago

I signed it! ;-) Q: Does @googlebot verify the commit's Author email against all addresses associated with one's GitHub user account, or ONLY against the gmail.com G ID? (I can change it it it HAS to be the gmail.com G ID.. or perhaps it digs, or at least does not mind, additional emails in --signoff Signed-off-by?

googlebot commented 7 years ago

CLAs look good, thanks!

vorburger commented 3 years ago

Whoa! I'm cleaning up many of my very old open PRs, from MANY years ago.. closing!