google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.42k stars 3.01k forks source link

Add CDNJS badge in readme #915

Closed kennynaoh closed 7 years ago

kennynaoh commented 7 years ago

This will add the badge to show its version on CDNJS and also link to its page on CDNJS!

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


kennynaoh commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

Garbee commented 7 years ago

This should not be on CDNJS. It is an application quick-start not a library to include at-will within your other projects.

kennynaoh commented 7 years ago

Actually, it is already on CDNJS https://cdnjs.com/libraries/web-starter-kit. We still can include it through CDNJS.

Garbee commented 7 years ago

Whether it is already there or not is hardly relevant. Having a badge on the project encourages its use. Which we shouldn't since that is not the way the repo is meant to be used/distributed.

It is about keeping usage clear to our end-users who are already confused about what tools apply where and in what context. This just muddies things even further and for something that is clearly an incorrect thing to be distributed using something like CDNJS. We're an application starter repo, not a library to be included at-will.

I understand someone may have added it to CDNJS without understanding the consequences it could have on developers. However, that doesn't mean the project should add a badge supporting that context.

kennynaoh commented 7 years ago

Thank you for your explanation. I got it.