Closed kennynaoh closed 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
This should not be on CDNJS. It is an application quick-start not a library to include at-will within your other projects.
Actually, it is already on CDNJS https://cdnjs.com/libraries/web-starter-kit. We still can include it through CDNJS.
Whether it is already there or not is hardly relevant. Having a badge on the project encourages its use. Which we shouldn't since that is not the way the repo is meant to be used/distributed.
It is about keeping usage clear to our end-users who are already confused about what tools apply where and in what context. This just muddies things even further and for something that is clearly an incorrect thing to be distributed using something like CDNJS. We're an application starter repo, not a library to be included at-will.
I understand someone may have added it to CDNJS without understanding the consequences it could have on developers. However, that doesn't mean the project should add a badge supporting that context.
Thank you for your explanation. I got it.
This will add the badge to show its version on CDNJS and also link to its page on CDNJS!