google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.43k stars 3.02k forks source link

Added smooth scroll #918

Open xLuis190 opened 7 years ago

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


Garbee commented 7 years ago

What problem is this solving?

Why did you solve the problem the way you did?

Why require jQuery just for this plugin when there are a few vanilla JS alternatives that don't need so much extra code pulled in?

Please provide some details with merge requests to projects. This will help the maintainers understand what you are trying to change and why.

Thank you.

QWp6t commented 7 years ago

lol @Garbee holster your pistol cowboy. It's prob just an accidental PR. Happens all the time man.

Garbee commented 7 years ago

Assuming it isn't that information is useful. If it is accidental, then they can easily mention that and close the issue.