search

google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.43k stars 3.02k forks source link

Swapping sw-toolbox and sw-precache for workbox-sw and workbox-build #937

Closed gauntface closed 6 years ago

gauntface commented 7 years ago

@jeffposnick @Garbee

What do people think of this?

The fiddling between dev and prod makes this a bit messy, so very open to alternative approaches.

I was thinking of adding dev and prod to app/third_party/ and then just switching the import script at run time but the version number is still going to be tricky.

addyosmani commented 6 years ago

I think there's actually value in us completing this PR and changing over WSK to just be a reference of a modern build process.

Between Matt's PR here, our docs and the PWA codelabs I've been able to migrate more of my older WSK-based apps to Workbox and found enough value here that it might be worth adjusting for the feedback and landing. Two cents :)

gauntface commented 6 years ago

No idea what the npm run test is doing. The build is fine but somewhere between git status and grep, something is borked.

gulp && git status | grep 'working directory clean' >/dev/null || (echo 'Please commit all changes generated by building'; exit 1)