search

google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.43k stars 3.02k forks source link

Compile SASS files in addition to CSS and SCSS files #949

Closed leolabs closed 3 years ago

leolabs commented 6 years ago

Just a small change in the gulpfile that includes .sass files in the compilation process

Edit: The PR tests failed because of a faulty git status message check. I've corrected it, so Travis should be happy now.

Garbee commented 6 years ago

The repository doesn't have any sass files by default. So why should this be included? If a developer wishes to use that syntax it is a clear opt-in choice and they'll need to make sure things are appropriately modified for it.

leolabs commented 6 years ago

@Garbee the repo doesn't include any scss files aswell, but still they are compiled when running gulp. As this change doesn't add any additional requirements and dependencies I don't see a problem there :)

Garbee commented 6 years ago

the repo doesn't include any scss files aswell

Oh yea, it is just pulling in MDL from the CDN. I thought we were requiring it and compiling builds internally.