search

google / web-starter-kit

Web Starter Kit - a workflow for multi-device websites
http://developers.google.com/web/starter-kit
Apache License 2.0
18.43k stars 3.02k forks source link

Adding Support for Jade. #952

Closed GyanendroKh closed 6 years ago

GyanendroKh commented 6 years ago

Adding support for Jade because writing Jade is better than HTML. Still HTML is also supported.

googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

GyanendroKh commented 6 years ago

I signed it!

On Sep 8, 2017 7:32 PM, "googlebot" notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/google/web-starter-kit/pull/952#issuecomment-328111230, or mute the thread https://github.com/notifications/unsubscribe-auth/APaixk1G8y8uDh6unalA85pFq8QEbFxfks5sgUjngaJpZM4PROOz .

googlebot commented 6 years ago

CLAs look good, thanks!

Garbee commented 6 years ago

because writing Jade is better than HTML.

Is there any data to back this assertion up? I for one find Jade awful to look at much less remember to write. What tangible benefit is there to including jade support by default, much less modifying the templates included to use it by default which encourages it directly.

Templates have come up before and are decidedly out of scope for WSK. Best this get left out as well since template engine choice is very much a per-project choice depending on many unique factors.

GyanendroKh commented 6 years ago

Oopss!!! I didn't know it was out of scope. But I think adding support for Jade is better. Instead of rewriting the same code again and again I think it is better to have it write once and include it where ever it is necessary.