google / webauthndemo

An example Node.js Relying Party implementation of the WebAuthn specification
https://try-webauthn.appspot.com
Apache License 2.0
563 stars 123 forks source link

Fix an issue that signature counter is 32-bit unsigned int #33

Closed kasecato closed 6 years ago

kasecato commented 6 years ago

If I can use JDK 8 I will use compareUnsigned.

cpiper commented 6 years ago

Good catch on this. JDK 7 is no longer officially supported via security updates, so moving to JDK 8 (and using compareUnsigned) seems appropriate.

kasecato commented 6 years ago

@cpiper Thanks. I made changes using JDK 8 and compareUnsigned.