search

google / webcrypto.dart

Cross-platform implementation of Web Cryptography APIs
https://pub.dev/packages/webcrypto
Apache License 2.0
81 stars 48 forks source link

Test with macos-16 on Github Actions #156

Closed jonasfj closed 3 weeks ago

jonasfj commented 1 month ago

Just curious to see how the tests goes :D

jonasfj commented 3 weeks ago

@HamdaanAliQuatil Thanks for trying, I propose that we live with the fact that these tests works on macos-14.

If we could reproduce these issues on a small example, it might be worth reporting them. But honestly, it's hard to know if this is a Github Actions issue, an issue with nanasess/setup-chromedriver@v2 or an issue with Flutter. It's probably Flutter or nanasess/setup-chromedriver or some interaction between them.

Actually, it could also be: https://github.com/google/webcrypto.dart/blob/master/tool/with-chromedriver.sh

It has a case for mac64 but not mac64_m1 which is also offered on https://chromedriver.storage.googleapis.com/.

But then again, we shouldn't be downloading chromedriver, I think nanasess/setup-chromedriver is doing that -- or maybe it's somehow picking the wrong one.

Or something else entirely is wrong. Let's land this as is, if you're interested in debugging it further feel free to copy as many PRs is it'll take :rofl: