google / webcrypto.dart

Cross-platform implementation of Web Cryptography APIs
https://pub.dev/packages/webcrypto
Apache License 2.0
81 stars 48 forks source link

Fix typo in test.yml #167

Closed jonasfj closed 3 weeks ago

jonasfj commented 3 weeks ago

Couldn't get the tests to run, so I just assumed it was a fluke. Only when I landed on master it was obvious that I had malformed YAML :see_no_evil:

jonasfj commented 3 weeks ago

88.7% coverage is not bad!

Not bad at all.

I'm not actually sure we'll get much more coverage by collecting coverage from integration tests, etc.

We have:

Code coverage around 80% is really good. If eventually we can cover most of the error cases, I think we should be very happy.

Let's not focus too much on the number, and focus more on what code paths are uncovered. (once we're done refactoring)