google / webrisk

Apache License 2.0
67 stars 34 forks source link

update /v1/ path in docs #26

Closed blackmad closed 1 year ago

blackmad commented 3 years ago

the code seems to imply this is moved to /v1/ - https://github.com/google/webrisk/blob/master/cmd/wrserver/main.go#L212

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

sp3nx0r commented 2 years ago

+1 tripped over this recently too

bsurmanski commented 2 years ago

Hi @blackmad, as the check above suggests, you must sign the Google Contributor License Agreement (CLA) for us to accept the pull request. I believe you are correct that the path should be /v1/, I'll double check with the relevant parties and approve once the CLA check passes. edit: I confirmed /v1/ is the correct path.