search

google / windowtester

Automatically exported from code.google.com/p/windowtester
Other
18 stars 23 forks source link

Code review request - Patches for tests #16

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes:

-Fixed RecorderLaunchConfigTest
-Removed license and code coverage tests (these components are not included 
anymore)
-Fixed NewAPIScreenCaptureTest (works now on windows platform, but there is 
still an issue with linux)
-Clean up code (remove unused imports, replace deprecated ui.pause() methods)

After the review, I'll merge this branch into:
/trunk

Regards,

Fred

Original issue reported on code.google.com by fred.g...@googlemail.com on 7 Jan 2013 at 1:00

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by fred.g...@googlemail.com on 7 Jan 2013 at 1:38

Attachments:

GoogleCodeExporter commented 9 years ago 
@Keerti: Please check if one of the patches
-2013-01-04_removedUnusedImportsAndReplacedUiPause_patch.txt
-2013-01-04_removedUnusedImportsAndReplacedUiPause_patch_2.txt
apply cleanly in your workspace. I'm having difficulties finding the right 
encoding.

Original comment by fred.g...@googlemail.com on 7 Jan 2013 at 1:41

GoogleCodeExporter commented 9 years ago 
Please also consider this patch.
I hope it's OK to bundle all these patches into one code review request.

Regards,

Fred

Original comment by fred.g...@googlemail.com on 7 Jan 2013 at 1:54

Attachments:

GoogleCodeExporter commented 9 years ago 
Fred,

All the patches look good, except for 
-2013-01-04_removedUnusedImportsAndReplacedUiPause_patch.txt. Was not able to 
apply it to my workspace.

You can go ahead and commit the rest.

Original comment by keertip@google.com on 8 Feb 2013 at 7:21

GoogleCodeExporter commented 9 years ago 
Keerti,

Thanks for reviewing the patches.
I attached the missing bits from 
"2013-01-04_removedUnusedImportsAndReplacedUiPause_patch.txt" that
should apply without a problem.

Is it OK to commit it?

Original comment by fred.g...@googlemail.com on 9 Feb 2013 at 8:54

Attachments:

GoogleCodeExporter commented 9 years ago 
Yes, go ahead and commit it.

Original comment by keertip@google.com on 15 Feb 2013 at 11:47

GoogleCodeExporter commented 9 years ago 
All patches committed, except changes for class KeyMapTextEntryTest, due to 
encoding problems.

Original comment by fred.g...@googlemail.com on 24 Feb 2013 at 1:18