search

google / wuffs

Wrangling Untrusted File Formats Safely
Other
4.16k stars 131 forks source link

Support prctl in musl libc based systems #124

Closed mterron closed 1 year ago

mterron commented 1 year ago

In musl libc based systems, <linux/prctl.h> is automatically pulled by <sys/prctl.h> so should not be included.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

nigeltao commented 1 year ago

Thanks for the bug report / pull request.

If you don't want to sign the CLA then, since this is a trivial patch, I'm happy to recreate and submit the change myself, if you want. It'd just mean that you don't get the formal attribution or authorship of having a PR merged.

mterron commented 1 year ago

Sounds good, go ahead

On Mon, 29 May 2023, 3:46 pm Nigel Tao, @.***> wrote:

Thanks for the bug report / pull request.

If you don't want to sign the CLA then, since this is a trivial patch, I'm happy to recreate and submit the change myself, if you want. It'd just mean that you don't get the formal attribution or authorship of having a PR merged.

— Reply to this email directly, view it on GitHub https://github.com/google/wuffs/pull/124#issuecomment-1566469925, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB2XW3TJTUFI5RG3IPSN6LXIQLZHANCNFSM6AAAAAAYSGH64Y . You are receiving this because you authored the thread.Message ID: @.***>

minitech commented 1 year ago

In musl libc based systems, <linux/prctl.h> is automatically pulled by <sys/prctl.h> so should not be included.

Is there a glibc that doesn’t do that?

mterron commented 1 year ago

~Not as far as I can tell~ I don't know.

On Mon, 29 May 2023, 7:23 pm Ryan O’Hara, @.***> wrote:

In musl libc based systems, <linux/prctl.h> is automatically pulled by <sys/prctl.h> so should not be included.

Is there a glibc that doesn’t do that?

— Reply to this email directly, view it on GitHub https://github.com/google/wuffs/pull/124#issuecomment-1566681442, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABB2XW46KIUEZDXMBRJIMYDXIRFIJANCNFSM6AAAAAAYSGH64Y . You are receiving this because you authored the thread.Message ID: @.***>