google / wuffs

Wrangling Untrusted File Formats Safely
Other
4.07k stars 129 forks source link

Attemps to pass frame buffer data to browser context #26

Closed jfurrow closed 4 years ago

jfurrow commented 4 years ago

Attempting to follow this article https://dev.to/chromiumdev/fast-gif-parsing-on-the-web-with-wasm--wuffs-48l4

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

nigeltao commented 4 years ago

Attempting to follow this article https://dev.to/chromiumdev/fast-gif-parsing-on-the-web-with-wasm--wuffs-48l4

Whilst that dev.to article ports Wuffs to Wasm, Wuffs does not primarily target Wasm, and this PR as is comments out a bunch of code that is actually used by the example program, as built by e.g. https://github.com/google/wuffs/blob/master/build-example.sh

See the screencast at https://github.com/google/wuffs/tree/master/example/gifplayer for the existing functionality.

jfurrow commented 4 years ago

Oh wow, I did not mean to open this PR against the main Wuffs repo, I was hastily trying to show this prototype to a co-worker and meant to open the PR against my own fork 🤦‍♂️

Sorry about that

nigeltao commented 4 years ago

Not a big problem. Have fun! :-)