google / wuffs

Wrangling Untrusted File Formats Safely
Other
4.07k stars 129 forks source link

Fix both imageviewers on X.org with DefaultDepth 30 #54

Closed pjanx closed 2 years ago

pjanx commented 2 years ago

Fixes #51.

google-cla[bot] commented 2 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

pjanx commented 2 years ago

@googlebot I signed it!

nigeltao commented 2 years ago

Thanks!

I have some minor quibbles, but I'll fix them in follow-up commits.

nigeltao commented 2 years ago

Having example/imageviewer use xrender means that it was now straightforward to add a zoom/magnify feature.

I also made some other tweaks. Let me know if I broke anything on DefaultDepth 30.

pjanx commented 2 years ago

I totally missed the build-example.sh script, or forgot about it at some point.

Indeed. Good gardening work, it's still working. You may simulate the situation by setting RGB24 on the application's main window, or the root window (which are both particularly annoying changes to make).