search

google / wuffs

Wrangling Untrusted File Formats Safely
Other
4.06k stars 129 forks source link

Fix Rust PNG benchmark #70

Closed MichaelMcDonnell closed 2 years ago

MichaelMcDonnell commented 2 years ago

The Rust PNG benchmark no longer compiles. This is similar to the issue that was fixed in pull request #68 for the Rust GIF benchmark. A new version of the png crate was published that broke clean builds. I've pinned the version to 0.17, which is the newest, and changed the code to use the new API.

NOTE: Parts of the png crate documentation hasn't been updated to correctly list the new transformation defaults. The documentation for the normalize_to_color8 method does say that the defaults changed from version 0.16 to 0.17.

MichaelMcDonnell commented 2 years ago

And thanks for your amazing work on Wuffs! I really appreciate how it is advancing the field of memory safety and performance!