Open shoyer opened 2 years ago
One of my original motivations for this is obviated by #50, which now allows us to handle variables in DatasetToChunks even if they don't include "chunked" dimensions.
It's still an open question whether this change would make Xarray-Beam more usable or not.
If we do not make this change, potentially we could enforce the invariant that key.offsets.keys() == dataset.dims.keys()
. This might be convenient for writing new transforms.
Currently we have (from https://xarray-beam.readthedocs.io/en/latest/read-write.html):
Should we instead omit
lat
andlon
from these keys? This is less explicit but also more flexible, e.g,. if replacing these dimensions entirely with different dimensions, you don't need to update the keys.