google / xarray-beam

Distributed Xarray with Apache Beam
https://xarray-beam.readthedocs.io
Apache License 2.0
125 stars 7 forks source link

Open multiple datasets at once from `DatasetToChunks`. #69

Closed alxmrs closed 1 year ago

alxmrs commented 1 year ago

Here is an initial implementation of #68.

shoyer commented 1 year ago

One other thing I'll note is that I've been formatting code in Xarray-Beam with the (Google internal) version of the "pyink" formatter, using 2 space indentation: https://github.com/google/pyink

It would be nice if you could apply that manually to this change -- ideally we would add some sort of automatic formatter checker.

alxmrs commented 1 year ago

As a small aside: I usually try to use the "commit suggestion" feature when I can. I didn't for these changes because I did them on an airplane yesterday :)

shoyer commented 1 year ago

@alxmrs please merge in main in order to test this

shoyer commented 1 year ago

@alxmrs there's a failing unit test -- can you fix it?

shoyer commented 1 year ago

LGTM to me (pending the formatter question).

Remember we need to merge this via the internal Google tool instead of the big green button on GitHub :)