Open cdleary opened 1 month ago
Failures:
$ bazel test -c opt --keep_going -- //xls/... -//xls/contrib/... |& tee /tmp/output.txt
[snip]
FAILED: Build did NOT complete successfully
//xls/build_rules/tests:__add_one_combinational_rtl FAILED TO BUILD
//xls/build_rules/tests:__add_one_dslx_verilog FAILED TO BUILD
//xls/build_rules/tests:__add_one_pipeline_rtl FAILED TO BUILD
//xls/build_rules/tests:__add_one_pipeline_rtl_proto FAILED TO BUILD
//xls/build_rules/tests:__add_one_pipeline_rtl_proto_fail FAILED TO BUILD
(Skipping other failed to build tests)
//xls/interpreter:block_interpreter_test FAILED in 0.3s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/interpreter/block_interpreter_test/test.log
//xls/interpreter:channel_queue_test FAILED in 0.3s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/interpreter/channel_queue_test/test.log
//xls/interpreter:ir_interpreter_test FAILED in 0.3s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/interpreter/ir_interpreter_test/test.log
//xls/interpreter:proc_interpreter_test FAILED in 0.3s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/interpreter/proc_interpreter_test/test.log
//xls/interpreter:serial_proc_runtime_test FAILED in 0.9s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/interpreter/serial_proc_runtime_test/test.log
//xls/jit:block_jit_test FAILED in 1.0s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/jit/block_jit_test/test.log
//xls/jit:jit_channel_queue_test FAILED in 1.2s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/jit/jit_channel_queue_test/test.log
//xls/jit:proc_jit_test FAILED in 0.9s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/jit/proc_jit_test/test.log
//xls/tools:gather_design_stats_test FAILED in 1.4s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/tools/gather_design_stats_test/test.log
//xls/tools:package_bazel_build_test FAILED in 1.0s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/tools/package_bazel_build_test/test.log
//xls/jit:function_jit_test FAILED in 1 out of 50 in 4.9s
Stats over 50 runs: max = 4.9s, min = 0.1s, avg = 0.3s, dev = 0.7s
/private/var/tmp/_bazel_cdleary/60c3e5ce2889de0dfd8db639786fbce7/execroot/com_google_xls/bazel-out/darwin_arm64-opt/testlogs/xls/jit/function_jit_test/shard_31_of_50/test.log
Executed 1248 out of 1451 tests: 1237 tests pass, 203 fail to build and 11 fail locally.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.
grpc issue:
looks like https://github.com/abseil/abseil-cpp/issues/1614, should be fixed w/ https://github.com/grpc/grpc/commit/bc044174401a0842b36b8682936fc93b5041cf88
should we try bumping grpc to https://github.com/grpc/grpc/releases/tag/v1.64.0 ?https://github.com/google/xls/blob/ec4df616bc8b3acd25db670259316e675b53edc9/dependency_support/load_external.bzl#L269-L283
Thanks for the pointer @proppy ! I'll try to do the dependency bump dance in a bit here and see how it goes.
The current 1.64.0 still has the c++20 regression (but a fix is in at head and they plan to backport it to 1.64).
For us, to update 1.64.0, we can use that release and then cherry-pick the fixing patch and applying it in the load_external.bzl.
Note, when updating grpc, this will also require to update or-tools last time I checked, so it might be a bit involved as that dependency also has not updated in a while.
Just an issue to track and take notes on the current (merged to google/xls) status of OS X support. Taking notes in an issue in the google/xls repo as it's (currently) canonical mainline. This is all work-aroundable, but my intent is to get mainline into a state where it "usually" works on OS X (via fixes and PRs if it happens to break).
WORKSPACE
file, almost everything works with the clang-15 installation that's present on latest OS XNote that if you don't comment out the hermetic toolchain registration it gives you an error indicating "you invoked llvm-ar with invalid command line arguments". Aside: I often use
//xls/ir:bits_test
as a simple canary target for a binary to build/test.grpc issue: