[cleanup] Get rid of need for external/ on z3 library includes

google / xls

XLS: Accelerated HW Synthesis

http://google.github.io/xls/

Apache License 2.0

1.21k stars 179 forks source link

[cleanup] Get rid of need for external/ on z3 library includes #1740

Closed cdleary closed 4 days ago

cdleary commented 4 days ago

Towards #1736

For verible we can probably patch the cc_library targets we depend on to add the include_prefix attribute similarly.

hzeller commented 4 days ago

Given that we want to use MODULE.bazel at some point, I think I'd avoid patching external cc_library() targets to avoid too much local modifications.

But I am wondering if I can convince the external Verible maintainer to work on a weekend hack to move everything down a directory in the upstream project: common/ -> verible/common/.... @hzeller WDYT :) ?

hzeller commented 4 days ago

I had a talk with the Verible maintainer ( :smiley: ) and he agreed to put everything under a subdirectory upstream on the weekend.

cdleary commented 4 days ago

@meheff fixed this for z3 downstream, thanks @meheff !