google / xrtl

Cross-platform Real-Time Rendering Library
Apache License 2.0
128 stars 26 forks source link

CHECK tests in logging_test.cc fail in weird ways #1

Open benvanik opened 7 years ago

benvanik commented 7 years ago

The tests pass on MacOS but not on Windows and some Linux variants. Not sure why, as most of this is from TensorFlow.

[ RUN      ] LoggingTest.FailedChecks
C:\users\ben\appdata\local\temp\_bazel_ben\4qe-y0h3\execroot\xrtl\xrtl\base\logging_test.cc(72): error: Death test: if ((!(false))) ::xrtl::internal::LogMessageFatal("C:\\users\\ben\\appdata\\local\\temp\\_bazel_ben\\4qe-y0h3\\execroot\\xrtl\\xrtl\\base\\logging_test.cc", 72) << "Check failed: " "false" " "
    Result: died but not with expected error.
  Expected: false
Actual msg: