search

google / xrtl

Cross-platform Real-Time Rendering Library
Apache License 2.0
128 stars 26 forks source link

Render test setup #35

Closed ScottTodd closed 7 years ago

ScottTodd commented 7 years ago

Addressed comments by splitting RenderTest into ImageComparison and ImageLoader under testing/. Can later add more infrastructure to generate and display diffs, approve changes, etc.

Still probably doesn't work on Windows without a runfiles fix or workaround.

ScottTodd commented 7 years ago

New tests pass on Windows now

googlebot commented 7 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot commented 7 years ago

CLAs look good, thanks!